Skip to content

Build(deps): Bump devcontainers features and stabilize flaky E2E tests#458

Merged
rvanmaanen merged 5 commits into
mainfrom
dependabot/devcontainers/devcontainers-all-bd7770f475
Jun 11, 2026
Merged

Build(deps): Bump devcontainers features and stabilize flaky E2E tests#458
rvanmaanen merged 5 commits into
mainfrom
dependabot/devcontainers/devcontainers-all-bd7770f475

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 4, 2026

Copy link
Copy Markdown
Contributor

Bumps devcontainers features in the / directory.

Updates ghcr.io/devcontainers/features/azure-cli from 1.2.9 to 1.3.0

Updates ghcr.io/devcontainers/features/docker-in-docker from 2.17.0 to 3.0.1

Additionally improves E2E test stability for collection-page search by updating FillBlazorInputAsync in tests/TechHub.E2E.Tests/Helpers/BlazorHelpers.cs so retry dispatches consistently target the originally matched input element instance (avoiding desktop/mobile duplicate input mismatches during rerenders).

Also stabilizes GitHubCopilotFeatures_TimelineEntry_ExpandCollapse_ShouldWork in tests/TechHub.E2E.Tests/Web/GitHubCopilotFeaturesTests.cs by removing the fixed-index assumption (Nth(1)) and selecting a timeline entry that is actually collapsed (aria-expanded='false') before asserting expand/collapse behavior.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file devcontainers_package_manager Pull requests that update devcontainers_package_manager code labels Jun 4, 2026
@dependabot dependabot Bot requested review from rajbos and rvanmaanen as code owners June 4, 2026 01:25
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file devcontainers_package_manager Pull requests that update devcontainers_package_manager code labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

✅ PR Preview Environment Removed

The preview environment for this pull request has been removed.

… 2 updates

Bumps the devcontainers-all group with 1 update in the / directory: ghcr.io/devcontainers/features/azure-cli.


Updates `ghcr.io/devcontainers/features/azure-cli` from 1.2.9 to 1.3.0

Updates `ghcr.io/devcontainers/features/docker-in-docker` from 2.17.0 to 3.0.1

---
updated-dependencies:
- dependency-name: ghcr.io/devcontainers/features/azure-cli
  dependency-version: 1.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: devcontainers-all
- dependency-name: ghcr.io/devcontainers/features/docker-in-docker
  dependency-version: 3.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: devcontainers-all
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title Build(deps): Bump the devcontainers-all group with 2 updates Build(deps): Bump the devcontainers-all group across 1 directory with 2 updates Jun 10, 2026
@dependabot dependabot Bot force-pushed the dependabot/devcontainers/devcontainers-all-bd7770f475 branch from f7412b8 to 34ea0cf Compare June 10, 2026 09:54
@rvanmaanen

Copy link
Copy Markdown
Collaborator

@copilot there is a flaky test, cna you try to improve it?

failed TechHub.E2E.Tests.Web.SearchTests.Search_OnCollectionPage_WorksCorrectly (3m 40s 106ms)
  System.TimeoutException : Timeout 60000ms exceeded.
  from /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/bin/Release/net10.0/TechHub.E2E.Tests.dll (net10.0|x64)
  Xunit.MicrosoftTestingPlatform.XunitException: System.TimeoutException : Timeout 60000ms exceeded.
    at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls) in /_/src/Playwright/Transport/Connection.cs:201
    at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal, String title)
    at Microsoft.Playwright.Core.Frame.WaitForFunctionAsync(String expression, Object arg, FrameWaitForFunctionOptions options) in /_/src/Playwright/Core/Frame.cs:677
    at TechHub.E2E.Tests.Helpers.BlazorHelpers.FillBlazorInputAsync(ILocator locator, String value, String urlQueryParam) in /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/Helpers/BlazorHelpers.cs:652
    at TechHub.E2E.Tests.Web.SearchTests.Search_OnCollectionPage_WorksCorrectly() in /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/Web/SearchTests.cs:267
    --- End of stack trace from previous location ---
/home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/bin/Release/net10.0/TechHub.E2E.Tests.dll (net10.0|x64) failed with 1 error(s) (16m 19s 948ms)

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@copilot there is a flaky test, cna you try to improve it?

...

Addressed in e055df5.

I updated FillBlazorInputAsync to retry against the same located input index instead of potentially switching to another matching input (desktop/mobile variant) during rerender. This makes the Search_OnCollectionPage_WorksCorrectly flow more deterministic and reduces the timeout flakiness you reported.

Copilot AI changed the title Build(deps): Bump the devcontainers-all group across 1 directory with 2 updates Build(deps): Bump devcontainers features and stabilize flaky E2E search test Jun 10, 2026
@rvanmaanen

Copy link
Copy Markdown
Collaborator

@copilot flaky tests:

Running tests from /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/bin/Release/net10.0/TechHub.E2E.Tests.dll (net10.0|x64)
failed�[m TechHub.E2E.Tests.Web.GitHubCopilotFeaturesTests.GitHubCopilotFeatures_TimelineEntry_ExpandCollapse_ShouldWork (1m 53s 762ms)�[m
Microsoft.Playwright.PlaywrightException : Locator expected to have attribute 'aria-expanded' 'false'
But was: 'true'
Call log:

  • Expect "ToHaveAttributeAsync" with timeout 60000ms
  • waiting for Locator(".features-timeline-entry").Nth(1).Locator(".features-timeline-card")
    123 × locator resolved to

    - unexpected value "true"
    Aria snapshot:
  • button "Organization-wide Custom Instructions ▶ Video Pro+ Enterprise Lets administrators define Copilot instructions that apply across all repositories in an organization. Enforce coding standards, preferred libraries, security practices, and domain context centrally — every developer's Copilot interactions automatically follow these guidelines without per-repo setup. Organization-wide Custom Instructions video thumbnail Watch full video →" [expanded]:
    • heading "Organization-wide Custom Instructions" [level=3]
    • text: ▶ Video Pro+ Enterprise
    • paragraph: Lets administrators define Copilot instructions that apply across all repositories in an organization. Enforce coding standards, preferred libraries, security practices, and domain context centrally — every developer's Copilot interactions automatically follow these guidelines without per-repo setup.
    • link "Organization-wide Custom Instructions video thumbnail":
      • /url: /github-copilot/videos/visual-studio-code-and-github-copilot-whats-new-in-1107
    • link "Watch full video →":
      • /url: /github-copilot/videos/visual-studio-code-and-github-copilot-whats-new-in-1107
        from /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/bin/Release/net10.0/TechHub.E2E.Tests.dll (net10.0|x64)
        Xunit.MicrosoftTestingPlatform.XunitException: Microsoft.Playwright.PlaywrightException : Locator expected to have attribute 'aria-expanded' 'false'
        But was: 'true'
        Call log:
      • Expect "ToHaveAttributeAsync" with timeout 60000ms
      • waiting for Locator(".features-timeline-entry").Nth(1).Locator(".features-timeline-card")
        123 × locator resolved to

        - unexpected value "true"
        Aria snapshot:
    • button "Organization-wide Custom Instructions ▶ Video Pro+ Enterprise Lets administrators define Copilot instructions that apply across all repositories in an organization. Enforce coding standards, preferred libraries, security practices, and domain context centrally — every developer's Copilot interactions automatically follow these guidelines without per-repo setup. Organization-wide Custom Instructions video thumbnail Watch full video →" [expanded]:
      • heading "Organization-wide Custom Instructions" [level=3]
      • text: ▶ Video Pro+ Enterprise
      • paragraph: Lets administrators define Copilot instructions that apply across all repositories in an organization. Enforce coding standards, preferred libraries, security practices, and domain context centrally — every developer's Copilot interactions automatically follow these guidelines without per-repo setup.
      • link "Organization-wide Custom Instructions video thumbnail":
        • /url: /github-copilot/videos/visual-studio-code-and-github-copilot-whats-new-in-1107
      • link "Watch full video →":
        • /url: /github-copilot/videos/visual-studio-code-and-github-copilot-whats-new-in-1107
          �[m at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, FrameExpectOptions expectOptions, Object expected, String message, String title) in //src/Playwright/Core/AssertionsBase.cs:97
          at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, ExpectedTextValue[] expectedText, Object expected, String message, String title, FrameExpectOptions options) in /
          /src/Playwright/Core/AssertionsBase.cs:69
          at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, ExpectedTextValue textValue, Object expected, String message, String title, FrameExpectOptions options) in /_/src/Playwright/Core/AssertionsBase.cs:61
          at TechHub.E2E.Tests.Web.GitHubCopilotFeaturesTests.<>c__DisplayClass24_0.<<GitHubCopilotFeatures_TimelineEntry_ExpandCollapse_ShouldWork>b__1>d.MoveNext() in /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/Web/GitHubCopilotFeaturesTests.cs:446
          --- End of stack trace from previous location ---
          at TechHub.E2E.Tests.Helpers.BlazorHelpers.ClickAndExpectAsync(ILocator locator, Func`1 assertion, Int32 totalTimeoutMs) in /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/Helpers/BlazorHelpers.cs:576
          at TechHub.E2E.Tests.Web.GitHubCopilotFeaturesTests.GitHubCopilotFeatures_TimelineEntry_ExpandCollapse_ShouldWork() in /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/Web/GitHubCopilotFeaturesTests.cs:445
          --- End of stack trace from previous location ---
          �[m�[m/home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/bin/Release/net10.0/TechHub.E2E.Tests.dll (net10.0|x64) failed with 1 error(s)�[m (26m 26s 708ms)�[m
          Exit code: 2

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@copilot flaky tests:

Running tests from /home/runner/work/techhub/techhub/tests/TechHub.E2E.Tests/bin/Release/net10.0/TechHub.E2E.Tests.dll (net10.0|x64)...

Addressed in cde6741.

I made the test stop assuming Nth(1) starts collapsed and instead select the first timeline entry that is actually collapsed (aria-expanded='false') before asserting expand/collapse behavior. This removes the index-based flakiness when multiple entries start expanded.

Copilot AI changed the title Build(deps): Bump devcontainers features and stabilize flaky E2E search test Build(deps): Bump devcontainers features and stabilize flaky E2E tests Jun 10, 2026
@rvanmaanen rvanmaanen merged commit 859be36 into main Jun 11, 2026
31 of 33 checks passed
@rvanmaanen rvanmaanen deleted the dependabot/devcontainers/devcontainers-all-bd7770f475 branch June 11, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file devcontainers_package_manager Pull requests that update devcontainers_package_manager code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants